-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI improvement of search box during transition on scrolling #205
Comments
Hey Id like to work on this |
@avinashbharti97. I don't think it would look better. Can you explain why you think it would look better? @kanishkarj. Please don't. Wait for consensus. Working on issues without consensus would waste your time, and there are plenty of other things to do. |
Fluid resizing of search bar on scrolling. Fixes sugarlabs#205 Reported-by:@avinashbharti97
Okay, sorry.. |
@quozl But as now padding for sugarlabs logo changes but not for search bar. Also after the scroll search box element starts touching the outer nav container but for element differentiation there should be some padding between parent container and child element. |
Good, thanks. I'll wait for others to assent. |
I agree with @avinashbharti97 :) |
Thanks. However, I'm looking for input from Sugar Labs members; on whether it will look better. This is a subjective issue. |
@avinashbharti97 great idea! but if it becomes too small it wouldn't look too good. If it's possible to make the search bar as responsive(Just reduce the size on scrolling) as the other element on the nav bar, than that solves the problem better. @VatsalBatra changing the radius if the search bar will distort the uniformity of the site as other elements are in full rectangles. |
Now that the search bar is being mentioned I have noticed that the search icon looks unproportional to the search bar maybe we can also resize it according to the search bar's size |
Probably best to look at this after upgrading to latest Bootstrap. #316 |
Hey, |
Hi @nikkuAg, yes and you open a PR if you have a fix. |
As now on scrolling the page navigation-bar content size changes relatively from large to small but the search box remains same
i think it will look better if the size of seach box also changes relatively something like this
The text was updated successfully, but these errors were encountered: