Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GITIAN: different sha256sum only win32-setup-unsigned.exe #82

Open
decryp2kanon opened this issue Feb 16, 2020 · 10 comments
Open

GITIAN: different sha256sum only win32-setup-unsigned.exe #82

decryp2kanon opened this issue Feb 16, 2020 · 10 comments
Labels
GITIAN help wanted Extra attention is needed

Comments

@decryp2kanon
Copy link
Contributor

decryp2kanon commented Feb 16, 2020

only WIN32 is different. i tried 3 times, but always different.

strange, in some case, sugarchain-0.16.3-win32-setup-unsigned.exe sha256hash is only changed. (the others OK) need verify.

  • 1st
    84633a80534732c73a2011e0783554d5ac0ba8b6ceed65c79c17b3f3dafd252b sugarchain-0.16.3-win32-setup-unsigned.exe

  • 2nd
    5c499f90f84fbac8768d74d1bd8d59a670420f9d5ea7a356b39972bce3afd704 sugarchain-0.16.3-win32-setup-unsigned.exe

  • 3rd
    a432640eb9247dca98a107350f4e9d741b4da84a3be8359fcba417d44755bc31 sugarchain-0.16.3-win32-setup-unsigned.exe

https://gist.github.com/cryptozeny/3501c77750541208b9dd1a9e9719fc53#gistcomment-3167642

@decryp2kanon decryp2kanon added GITIAN help wanted Extra attention is needed labels Feb 16, 2020
@decryp2kanon

This comment has been minimized.

@decryp2kanon decryp2kanon changed the title GITIAN: sha256sum is different on win32-setup-unsigned.exe GITIAN: different sha256sum only win32-setup-unsigned.exe Feb 21, 2020
@volbil

This comment has been minimized.

@decryp2kanon

This comment has been minimized.

@decryp2kanon

This comment has been minimized.

@decryp2kanon
Copy link
Contributor Author

decryp2kanon commented Feb 22, 2020

volbil's commit looks fine. just now i assueme this MSSE2 flag for 32bit (dash) by @cryptozeny

https://github.com/sugarchain-project/sugarchain/blob/cbd806eaf3b3e15c64b334aa74b49107cd10e9c2/.travis.yml#L27

https://github.com/sugarchain-project/sugarchain/blob/cbd806eaf3b3e15c64b334aa74b49107cd10e9c2/.travis.yml#L66

# BEGIN - DISABLE SHARED
# WIN_BITCOIN_CONFIG="--disable-shared"
# mv ${DISTNAME}/bin/*.dll ${DISTNAME}/lib/
if [ -f ${DISTNAME}/bin/*.dll ]; then
mv ${DISTNAME}/bin/*.dll ${DISTNAME}/lib/
fi
# END - DISABLE SHARED

@okoto-xyz
Copy link

Previously, a similar bug occurred in bitzeny's gitian build.
At that time it seemed to be NSIS issue.
What version of OS is gitian build environment for sugarchain?

image

@cryptozeny
Copy link
Member

cryptozeny commented Feb 25, 2020

@okoto-xyz its version is original btc 0.16.3

it seems same issue. whats zny's solution? NSIS installer?

@decryp2kanon
Copy link
Contributor Author

decryp2kanon commented Feb 25, 2020

issue on BitZeny

Deleted User12/17/2018
https://github.com/BitzenyCoreDevelopers/gitian.sigs/blob/93221d4b330f43114ad706fd32f1df01a47f2653/2.0.2-win-unsigned/okoto/bitzeny-win-2.0-build.assert
gitianビルドでbitzeny-2.0.2-win*-setup-unsigned.exeの結果が毎回異なります。
.exeのリソースのアイコン周りのバイナリが異なるようでNSISのバグっぽいですが、
既にissue上がってたりしますでしょうか。
GitHub
BitzenyCoreDevelopers/gitian.sigs
Trusted Build Process signatures. Contribute to BitzenyCoreDevelopers/gitian.sigs development by creating an account on GitHub.

じんさん12/17/2018
毎回違った気がした(ような気がする
ん?違ったら意味ねぇな()
Deleted User12/17/2018
アイコンshare/pixmaps/bitcoin.icoの形式によるようで以前のコミットのものにしたら
setup.exeのアイコン周りのバイナリは毎回一致するようになるようですが、
中身のuninstall.exeが毎回違うようでした。
share/setup.nsi.inのmodern-uninstall.icoも別のものにするか、
nsisのバージョンを上げれば直るかもしれません。
Deleted User12/17/2018
3.0?の開発状況はよくわかりませんが、gitianのビルド環境が
trusty(nsis2.46-7)からxenial(nsis2.50-1)かbionic(nsis2.51-1)になるのであれば直るかもしれません。
hitobb12/18/2018
ありがとうございます。ロードマップとしては、そのうちベースのBTCを0.17にあげる予定があり、そのタイミングでgitian環境は変わります。恒久的な対策はそこで実施しますね。
issue上がっていないので、お手間でなければ頂けると助かります(日本語でも構いません)

solution

3.0?の開発状況はよくわかりませんが、gitianのビルド環境が
trusty(nsis2.46-7)からxenial(nsis2.50-1)かbionic(nsis2.51-1)になるのであれば直るかもしれません。

@decryp2kanon
Copy link
Contributor Author

@okoto-xyz BTW, i invited you as member again. please join 😅 pls check your email or visit.
https://github.com/sugarchain-project

@decryp2kanon
Copy link
Contributor Author

i realized sometimes its correct, but sometimes not. update win32 installer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GITIAN help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants