Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use make to always get latest dependent libs #198

Open
marcoarthur opened this issue Jan 5, 2018 · 4 comments
Open

Use make to always get latest dependent libs #198

marcoarthur opened this issue Jan 5, 2018 · 4 comments
Assignees

Comments

@marcoarthur
Copy link
Contributor

Write dependency rules to modules, so we guarantee we build gorjun against the latest go modules. Since this is the rule for Jenkins build

@marcoarthur
Copy link
Contributor Author

make should follow same approach used to build gorjun in Jenkins. This way we garantee that won't crash when official building. Reference:

https://github.com/subutai-io/gorjun/blob/dev/Jenkinsfile

@crioto
Copy link
Member

crioto commented Jan 5, 2018

@marcoarthur basically single go get -u execution on dev's host should bring you latest libraries. This is not used in jenkins file due to it's go environment. go get -u just won't work on jenkins.

@marcoarthur
Copy link
Contributor Author

Yeah I think so, but the problem here is that go get -u takes too long since that potentially could update all system. Better approach is needed

@dilshat
Copy link
Member

dilshat commented Jan 5, 2018

Look at vendoring in go dependency management

@marcoarthur marcoarthur self-assigned this Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants