-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PHP] block comments are not working as expected if they are placed inside a <script> tag #3812
Comments
It's always helpful to include your sample code as text as well as the screenshot, so testers can copy it without retyping. |
PHP tags are Packages/PHP/JavaScript (PHP).sublime-syntax Lines 37 to 45 in 74c43d2
PHP Source.sublime-syntax is mainly designed to switch between html<->php. Not sure what a solution would look like without risk of hitting 25k context sanity limit and keep already significant complexity in sane limits. It's hard to mix 2 context sensitive syntaxes such as PHP and JavaScript without bloating resource usage and complexity. Not sure whether its worth for such a tiny edge case. There are likely more when using PHP within JS/CSS. Those are designed to take simple php expressions only. |
What happened?
After applying the patch from this GitHub repository: https://github.com/jfcherng-sublime/ST-my-settings/blob/master/scripts/update_official_packages.sh, the overall functionality seems to be working fine.
However, there is an issue with the PHP block comment inside the script tag, which is not functioning correctly.
followed by #3811
The text was updated successfully, but these errors were encountered: