Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace org.json with Jackson #1

Open
sublimator opened this issue Dec 22, 2017 · 5 comments
Open

Replace org.json with Jackson #1

sublimator opened this issue Dec 22, 2017 · 5 comments

Comments

@sublimator
Copy link
Owner

The former is horrifically slow!

@sublimator
Copy link
Owner Author

@sappenin
Copy link

sappenin commented Jun 1, 2020

@sublimator I recently had a need for this library, and didn't realize you had a more mature fork. Glad I happened upon this version!

I have a project that's using Jackson (but also imports ripple-lib-java) and found a nice bridge in the Jackson family (https://github.com/FasterXML/jackson-datatypes-misc/tree/master/json-org). It worked nicely as an API bridge to move from the org.json produced by ripple-lib-java into my code that's based on Jackson. For performance, it would still be good to replace org.json entirely, however.

Connecting this issue with #11, I've had extremely good experiences with the immutables library. Not only does it have a very nice API and ensure immutability, it's also nicely compatible with Jackson and removes a lot of boiler plate code. Also very performant in my apps that are very high TPS.

@sublimator
Copy link
Owner Author

sublimator commented Jun 1, 2020 via email

@sublimator
Copy link
Owner Author

sublimator commented Jun 1, 2020 via email

@sublimator
Copy link
Owner Author

Found the issue/thread!

I've had extremely good experiences with the immutables library.

Oh right, most the classes are "effectively" immutable, with no in place modifications etc and generally you aren't allowed to construct invalid objects.

It would be nice to check out immutable but I don't personally have the need/time atm.

I'm not sure how much work it would be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants