Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Enabling multi-passage duplication for turbomachinery cases. #2312

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

FabianYan2010
Copy link

@FabianYan2010 FabianYan2010 commented Jun 25, 2024

Proposed Changes

Multi-passage or full-annulus simulation is very important for turbomachinery case. For example, say one wants to simulate the circumferential features like rotating-stall or inlet distortion effect. Usually one first conducts single-passage RANS computation, then starts multi-passage or even full-annulus URANS from that converged single-passage solution. To do this in SU2, one meets two problems:

  1. Replicate the single-passage grid to user-defined number of passages (including full-annulus)
  2. Replicate the single-passage solution

The proposed changes solve the two above mentioned problems.
This function is one of a series of features that enable SU2 to run URANS for turbomachinery cases, which have been shared to the SU2-Turbo group recently.
This function has been used for my research for almost one year. If necessary, I could add simple test cases as well.

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

chuanxiang yan added 3 commits June 25, 2024 14:26
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but this is a lot of code for a niche feature. Please consider implementing this via the python wrapper.

@pcarruscag pcarruscag changed the title Enabling multi-passage duplication for turbomachinery cases. [WIP] Enabling multi-passage duplication for turbomachinery cases. Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants