-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Pressure Based Flow Solver V8 #2210
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Target branch is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oof... I hope you have time because there's wayyyy too much duplicate code here.
But kudos for bringing this up to speed of course. |
Yes, I plan to invest some time here and there to finish this, but, not everything here falls under my expertise. I am currently making CPBIncEulerVariable to inherit CFlowVariable (instead of CVariable). This should already remove some duplication. |
And let's throw out everything that is not related to the PB solver. |
I pointed the PB solver to the existing vorticity and strain mag. functions and removed the heat.cpp file. If you can make your testcase available, then we can already setup our own regression tests. |
Test cases added, |
@bigfooted : I fixed the CFlowVariable thing. Many CPBIncEulerVariables are now commented out. CPBIncEulerSolver has the same behaviour as before now, however, PBIncNVSolver is crashing due to the initialization of vorticity. Maybe you can fix that. |
NSSolver Vorticity error fixed. RANS Solver starts without crashing, results yet to be benchmarked. |
Proposed Changes
Give a brief overview of your contribution here in a few sentences.
Reimplemented pressure-based solver from feature_Pressure_based into the development branch.
Related Work
branch: feature_Pressure_based
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --all
to format old commits.Euler Solver: Incompressible cylinder case Pressure based (PB) vs Density Based (DB)
Navier Stokes Solver: Incompressible Hydrofoil case Pressure-based (PB) vs Density Based (DB)
Still TODOs