Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Addition of SLAU, SLAU2, and AUSM+-Up Schemes to NEMO #1943

Draft
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

WallyMaier
Copy link
Contributor

Proposed Changes

This adds more AUSM family schemes.

Related Work

This is a continuation of PR #1773

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@pr-triage pr-triage bot added the PR: draft label Feb 28, 2023
Comment on lines 504 to 505
const su2double astarL = sqrt(2.0*(Gamma-1.0)/(Gamma+1.0)*Enthalpy_i);
const su2double astarR = sqrt(2.0*(Gamma-1.0)/(Gamma+1.0)*Enthalpy_j);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity is this still accurate for NEMO?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not exactly, though we I need to make some changes so we include local gamma values (Gamma_i and j).

Comment on lines +518 to +531

const su2double MFsq = 0.5*(mL*mL+mR*mR);
const su2double param1 = max(MFsq, Minf*Minf);
const su2double Mrefsq = min(1.0, param1);

const su2double fa = 2.0*sqrt(Mrefsq)-Mrefsq;

const su2double alpha = 3.0/16.0*(-4.0+5.0*fa*fa);
const su2double beta = 1.0/8.0;

if (fabs(mL) <= 1.0) {
const su2double p1 = 0.25*(mL+1.0)*(mL+1.0);
const su2double p2 = (mL*mL-1.0)*(mL*mL-1.0);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm recognizing some of this stuff, is it possible to share something with the ideal gas schemes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think all of the these interface Mach functions are dependent on projected velocities, Mach, and pressures. So yeah all should be able to shared.

@WallyMaier WallyMaier changed the title Addition of SLAU, SLAU2, and AUSM+-Up Schemes to NEMO [WIP] Addition of SLAU, SLAU2, and AUSM+-Up Schemes to NEMO Feb 28, 2023
@stale
Copy link

stale bot commented May 21, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still a relevant issue please comment on it to restart the discussion. Thank you for your contributions.

@stale stale bot added the stale label May 21, 2023
@stale stale bot removed the stale label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants