-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Addition of SLAU, SLAU2, and AUSM+-Up Schemes to NEMO #1943
base: develop
Are you sure you want to change the base?
Conversation
const su2double astarL = sqrt(2.0*(Gamma-1.0)/(Gamma+1.0)*Enthalpy_i); | ||
const su2double astarR = sqrt(2.0*(Gamma-1.0)/(Gamma+1.0)*Enthalpy_j); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just out of curiosity is this still accurate for NEMO?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not exactly, though we I need to make some changes so we include local gamma values (Gamma_i and j).
|
||
const su2double MFsq = 0.5*(mL*mL+mR*mR); | ||
const su2double param1 = max(MFsq, Minf*Minf); | ||
const su2double Mrefsq = min(1.0, param1); | ||
|
||
const su2double fa = 2.0*sqrt(Mrefsq)-Mrefsq; | ||
|
||
const su2double alpha = 3.0/16.0*(-4.0+5.0*fa*fa); | ||
const su2double beta = 1.0/8.0; | ||
|
||
if (fabs(mL) <= 1.0) { | ||
const su2double p1 = 0.25*(mL+1.0)*(mL+1.0); | ||
const su2double p2 = (mL*mL-1.0)*(mL*mL-1.0); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm recognizing some of this stuff, is it possible to share something with the ideal gas schemes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually think all of the these interface Mach functions are dependent on projected velocities, Mach, and pressures. So yeah all should be able to shared.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still a relevant issue please comment on it to restart the discussion. Thank you for your contributions. |
Proposed Changes
This adds more AUSM family schemes.
Related Work
This is a continuation of PR #1773
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.