From 3ddd27ad8c4cfe3170ff1648f86842bfa4bedb1d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Johannes=20Bl=C3=BChdorn?= Date: Wed, 19 Jul 2023 18:10:28 +0200 Subject: [PATCH 1/4] OpDiLib update. --- externals/opdi | 2 +- meson_scripts/init.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/externals/opdi b/externals/opdi index 913535c4909..c42cca71a3d 160000 --- a/externals/opdi +++ b/externals/opdi @@ -1 +1 @@ -Subproject commit 913535c490989ea9aa654e8c7df41c7e3718a5a2 +Subproject commit c42cca71a3d0b44fb482e268ecd40b623e71776b diff --git a/meson_scripts/init.py b/meson_scripts/init.py index 372e77bc228..be044f16c53 100755 --- a/meson_scripts/init.py +++ b/meson_scripts/init.py @@ -59,7 +59,7 @@ def init_submodules( github_repo_codi = "https://github.com/scicompkl/CoDiPack" sha_version_medi = "aafc2d1966ba1233640af737e71c77c1a86183fd" github_repo_medi = "https://github.com/SciCompKL/MeDiPack" - sha_version_opdi = "913535c490989ea9aa654e8c7df41c7e3718a5a2" + sha_version_opdi = "c42cca71a3d0b44fb482e268ecd40b623e71776b" github_repo_opdi = "https://github.com/SciCompKL/OpDiLib" sha_version_meson = "41c650a040d50e0912d268af7a903a9ce1456dfa" github_repo_meson = "https://github.com/mesonbuild/meson" From d2f81f4adead96249a8314d14fedd3cddf37723e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Johannes=20Bl=C3=BChdorn?= Date: Thu, 20 Jul 2023 13:40:54 +0200 Subject: [PATCH 2/4] Update bounds checking parameters. --- Common/include/basic_types/ad_structure.hpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/Common/include/basic_types/ad_structure.hpp b/Common/include/basic_types/ad_structure.hpp index adb9b94e71a..6721808119f 100644 --- a/Common/include/basic_types/ad_structure.hpp +++ b/Common/include/basic_types/ad_structure.hpp @@ -384,16 +384,14 @@ FORCEINLINE void SetDerivative(int index, const double val) { if (index == 0) // Allow multiple threads to "set the derivative" of passive variables without causing data races. return; - using BoundsChecking = codi::GradientAccessTapeInterface::BoundsChecking; - AD::getTape().setGradient(index, val, BoundsChecking::False); + AD::getTape().setGradient(index, val, codi::AdjointsBoundsChecking::False); } // WARNING: For performance reasons, this method does not perform bounds checking. // If called after tape evaluations, the adjoints should exist. // Otherwise, please ensure sufficient adjoint vector size by a call to AD::ResizeAdjoints(). FORCEINLINE double GetDerivative(int index) { - using BoundsChecking = codi::GradientAccessTapeInterface::BoundsChecking; - return AD::getTape().getGradient(index, BoundsChecking::False); + return AD::getTape().getGradient(index, codi::AdjointsBoundsChecking::False); } FORCEINLINE bool IsIdentifierActive(su2double const& value) { From f4feba9c2a7ae3c2fdb68f20fcbe998fe02f9388 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Johannes=20Bl=C3=BChdorn?= Date: Tue, 25 Jul 2023 12:43:16 +0200 Subject: [PATCH 3/4] Update bounds checking parameters. --- Common/include/basic_types/ad_structure.hpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Common/include/basic_types/ad_structure.hpp b/Common/include/basic_types/ad_structure.hpp index 6721808119f..8a46096a58e 100644 --- a/Common/include/basic_types/ad_structure.hpp +++ b/Common/include/basic_types/ad_structure.hpp @@ -384,14 +384,14 @@ FORCEINLINE void SetDerivative(int index, const double val) { if (index == 0) // Allow multiple threads to "set the derivative" of passive variables without causing data races. return; - AD::getTape().setGradient(index, val, codi::AdjointsBoundsChecking::False); + AD::getTape().setGradient(index, val, codi::AdjointsManagement::Manual); } // WARNING: For performance reasons, this method does not perform bounds checking. // If called after tape evaluations, the adjoints should exist. // Otherwise, please ensure sufficient adjoint vector size by a call to AD::ResizeAdjoints(). FORCEINLINE double GetDerivative(int index) { - return AD::getTape().getGradient(index, codi::AdjointsBoundsChecking::False); + return AD::getTape().getGradient(index, codi::AdjointsManagement::Manual); } FORCEINLINE bool IsIdentifierActive(su2double const& value) { From a9a7ad82c6b65fd170b48797eb11228f9d32b290 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Johannes=20Bl=C3=BChdorn?= Date: Wed, 26 Jul 2023 14:03:55 +0200 Subject: [PATCH 4/4] Update CoDiPack version. --- externals/codi | 2 +- meson_scripts/init.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/externals/codi b/externals/codi index 4237fe38c90..17232fed052 160000 --- a/externals/codi +++ b/externals/codi @@ -1 +1 @@ -Subproject commit 4237fe38c90b83541f699bd84e00c656099b7d18 +Subproject commit 17232fed05245dbb8f04a31e274a02d53458c75c diff --git a/meson_scripts/init.py b/meson_scripts/init.py index 1e70f41296f..eb69728e2a0 100755 --- a/meson_scripts/init.py +++ b/meson_scripts/init.py @@ -55,7 +55,7 @@ def init_submodules( # This information of the modules is used if projects was not cloned using git # The sha tag must be maintained manually to point to the correct commit - sha_version_codi = "4237fe38c90b83541f699bd84e00c656099b7d18" + sha_version_codi = "17232fed05245dbb8f04a31e274a02d53458c75c" github_repo_codi = "https://github.com/scicompkl/CoDiPack" sha_version_medi = "aafc2d1966ba1233640af737e71c77c1a86183fd" github_repo_medi = "https://github.com/SciCompKL/MeDiPack"