From 3ff2cc2337d8dc1a886d9f1398380dbcbc27b445 Mon Sep 17 00:00:00 2001 From: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com> Date: Fri, 25 Oct 2024 07:00:11 -0700 Subject: [PATCH] Apply suggestions from code review --- Common/src/CConfig.cpp | 8 ++++++-- config_template.cfg | 4 ++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/Common/src/CConfig.cpp b/Common/src/CConfig.cpp index e3db9abb0e0..8a60579189c 100644 --- a/Common/src/CConfig.cpp +++ b/Common/src/CConfig.cpp @@ -1781,8 +1781,12 @@ void CConfig::SetConfig_Options() { * Parameters in square brackets are optional, parameter "starting iteration" only valid with parameter "acceptable linear residual". * Factor down generally <1.0, factor up generally > 1.0 to cause the CFL to increase when the under-relaxation parameter is 1.0 * and to decrease when the under-relaxation parameter is less than 0.1. Factor is multiplicative. \ingroup Config*/ - default_cfl_adapt[0] = 0.1; default_cfl_adapt[1] = 2.0; default_cfl_adapt[2] = 10.0; default_cfl_adapt[3] = 1e10; - default_cfl_adapt[4] = 0.001; default_cfl_adapt[5] = 0.0; + default_cfl_adapt[0] = 0.1; + default_cfl_adapt[1] = 1.2; + default_cfl_adapt[2] = 10.0; + default_cfl_adapt[3] = 100.0; + default_cfl_adapt[4] = 0.001; + default_cfl_adapt[5] = 0.0; addDoubleListOption("CFL_ADAPT_PARAM", nCFL_AdaptParam, CFL_AdaptParam); /* DESCRIPTION: Reduction factor of the CFL coefficient in the adjoint problem */ addDoubleOption("CFL_REDUCTION_ADJFLOW", CFLRedCoeff_AdjFlow, 0.8); diff --git a/config_template.cfg b/config_template.cfg index 2d1ef4884c0..8a953b7be78 100644 --- a/config_template.cfg +++ b/config_template.cfg @@ -1390,8 +1390,8 @@ CFL_ADAPT= NO % % Parameters of the adaptive CFL number (factor-down, factor-up, CFL min value, % CFL max value, acceptable linear solver convergence, starting iteration) -% After the starting iteration has passed, local CFL increases by factor-up until max if the solution rate of change is not limited, -% and acceptable linear convergence is achieved. It is reduced if rate is limited, or if there +% After the starting iteration has passed, local CFL increases by factor-up until max if the solution rate of +% change is not limited, and acceptable linear convergence is achieved. It is reduced if rate is limited, or if there % is not enough linear convergence, or if the nonlinear residuals are stagnant and oscillatory. % It is reset back to min when linear solvers diverge, or if nonlinear residuals increase too much. CFL_ADAPT_PARAM= ( 0.1, 2.0, 10.0, 1e10, 0.001, 0)