Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to more defined plugin paradigm #34

Open
jbodah opened this issue May 22, 2015 · 1 comment
Open

Move to more defined plugin paradigm #34

jbodah opened this issue May 22, 2015 · 1 comment

Comments

@jbodah
Copy link
Collaborator

jbodah commented May 22, 2015

Right now all of the plugins are nested in /pre_commit. There are a few issues with this:

  1. We'll probably want to allow for plugins like RSpec to be called with any hook (e.g. pre-push)
  2. More difficult to scale. The more plugins we add the bigger this repo gets. I can imagine some plugins having specific configuration
  3. Want to support different environments (e.g. Minitest vs. RSpec)

Minitest has a very nice plugin system that works very similarly to how we load them here: https://github.com/stupied4ever/git-hooks/blob/master/lib/git-hooks.rb#L29

Minitest's plugin load: https://github.com/seattlerb/minitest/blob/master/lib/minitest.rb#L78

@jbodah jbodah changed the title Move hooks to plugin paradigm Move to more defined plugins paradigm May 22, 2015
@jbodah jbodah changed the title Move to more defined plugins paradigm Move to more defined plugin paradigm May 22, 2015
@stupied4ever
Copy link
Owner

I was plaining to do it some day, but for sure, this description will help in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants