-
-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Emscripten CI tests #977
Comments
Yes, I tried to fix the emscripten thing a couple of days ago, but I failed to understand what is going on in the code. It would be nice if you could have a look. |
I believe the JS test might not be correct. The functions are not directly available after the import (afaik), so in this code:
I don't think This is also why https://github.com/strukturag/libheif/blob/master/examples/demo.html runs on Another issue is that it cuts off the logging, so its hard to see what is actually wrong. |
So there is a regression which will break existing users code after an update. The old version of the JS code published a global In any case, that's what this issue is for ;-) The broken behaviour should be fixed. |
In that case, probably. I only looked at the example.html, and that still worked, didn't know there was a unit test. Not completely sure if it can be fixed in Emscripten, I think they intentionally changed it to work this way. Perhaps we should look at how it currently wraps the generated JS too, it does some magic which shouldn't really be necessary anyway: https://github.com/strukturag/libheif/blob/master/pre.js#L35 and https://github.com/strukturag/libheif/blob/master/post.js |
Reading this page it seems that Maybe we can add the option when USE_WASM is 0, because in that case it doesn't have to load WebAssembly and that should make it loadable in a sync way, |
Resolves: strukturag#977.
Resolves: strukturag#977.
#925 broke the Emscripten CI, so adding an issue to bring back testing of Emscripten.
Originally posted by @fancycode in #925 (comment)
The text was updated successfully, but these errors were encountered: