-
-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.17.1 32-bit compile fails #1008
Comments
See also #948 (comment) and 963f7bf Note also that there were no such warnings building 1.17.1 on e.g. mingw32/clang32... What system & compiler is this? |
There are, however, numerous other warnings when building for 32-bit that could be problematic:
|
Now, the question is: if we use Is there a need to support large HEIF files (>4 GB) on 32bit systems? |
That's right. So you'd still need to keep those int64/uint64 internally when parsing and only at the actual file/memory access time dynamically detect >4GB and throw an unsupported error on 32-bit systems. Not sure if it's worth it though knowing they're being slowly phased out... Anyway, probably a separate issue to the 32-bit libjpeg one the OP reported. |
The error message of the OP says:
Note the |
my jpeg lib is build from jpegsrc.v9e.tar.gz from http://www.ijg.org/files |
@freakout42 Can you test if it works with a version from https://libjpeg-turbo.org/ ? |
with libjeeg-turbo different error:
|
I'm guessing your cmake step did not have Can you see why that happened in the cmake tests? |
when i do not explicitely set the jpeg-libs and -include paths but let pkgconfig do the job libheif compiles and works perfectly - thanks for your help and for libheif |
[ 97%] Building CXX object libheif/plugins/CMakeFiles/heif-jpegenc.dir/encoder_jpeg.cc.o /home/axel/p/rpm/BUILD/libheif-1.17.1/libheif/plugins/encoder_jpeg.cc: In function 'heif_error jpeg_encode_image(void*, const heif_image*, heif_image_input_class)': /home/axel/p/rpm/BUILD/libheif-1.17.1/libheif/plugins/encoder_jpeg.cc:366:37: error: invalid conversion from 'long unsigned int*' to 'size_t*' {aka 'unsigned int*'} [-fpermissive] 366 | jpeg_mem_dest(&cinfo, &outbuffer, &outlength); | ^~~~~~~~~~ | | | long unsigned int* In file included from /home/axel/p/rpm/BUILD/libheif-1.17.1/libheif/plugins/encoder_jpeg.cc:33: /opt/jpeg/include/jpeglib.h:981:41: note: initializing argument 3 of 'void jpeg_mem_dest(j_compress_ptr, unsigned char**, size_t*)' 981 | size_t * outsize)); | ~~~~~~~~~^~~~~~~ /opt/jpeg/include/jpeglib.h:877:25: note: in definition of macro 'JPP' 877 | #define JPP(arglist) arglist | ^~~~~~~ make[2]: *** [libheif/plugins/CMakeFiles/heif-jpegenc.dir/build.make:76: libheif/plugins/CMakeFiles/heif-jpegenc.dir/encoder_jpeg.cc.o] Error 1 make[1]: *** [CMakeFiles/Makefile2:361: libheif/plugins/CMakeFiles/heif-jpegenc.dir/all] Error 2 make: *** [Makefile:156: all] Error 2
The text was updated successfully, but these errors were encountered: