Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New shapes #3

Open
RVR06 opened this issue Feb 3, 2023 · 4 comments
Open

New shapes #3

RVR06 opened this issue Feb 3, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@RVR06
Copy link

RVR06 commented Feb 3, 2023

Shape library will benefit some addition. Obvious ones would be desktop app & cli to mirror what we have for web browser & mobile, and better identify entry points in such use cases. I give a try and end up with this one for desktop:

image

Don't pay attention to the color, they are of course bound to matching properties.

Is this something we could submit PR for?

@simonbrowndotje
Copy link
Contributor

The code in this repo isn't yet running in the on-premises installation and cloud service, so I'd rather not add any new features quite yet ... but leave it with me and I will add desktop app and cli/terminal style shapes for you. 👍

@simonbrowndotje
Copy link
Contributor

A window shape is now available.

Screenshot 2023-02-20 at 07 25 13

For the other shape (terminal, cli ... name to be decided), I was thinking of putting a > or > _ symbol in the lower left of the same shape. Thoughts?

@RVR06
Copy link
Author

RVR06 commented Feb 20, 2023

Perfect. I was thinking about having >_ in place of 3 buttons for terminal, to end up with 3 different shapes.
Kind of:
image

@simonbrowndotje simonbrowndotje added the enhancement New feature or request label Mar 21, 2023
@frank-zwarthoed
Copy link

It would also be helpful to enable use of the octagon shape in styling of elements.

In my use case it would help to create views to describe how the ideas of cell based architecture can be applied (https://github.com/wso2/reference-architecture/blob/master/reference-architecture-cell-based.md).

The octagon shape seems to be available in the bootstrap icon library, so implementation in structurizr-ui seems doable. It would however also mean a (minor) modification of struturizr-dsl (and thus structurizr-java) in order to define the octagon shape in the styling section. The modification seems to also require updates to other repositories than structurizr-ui.

Happy to help, but I may need some guidance on how to introduce the required modifications.
I managed to modify and unit-test the libraries mentioned above using a containerized JDK environment. But I haven't been able to demonstrate the result as I'm struggling on how to use the updated dependencies during the build of structurizr-lite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants