Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host images from Lite #165

Open
simonbrowndotje opened this issue Oct 9, 2024 · 2 comments
Open

Host images from Lite #165

simonbrowndotje opened this issue Oct 9, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@simonbrowndotje
Copy link
Contributor

Description

See #164

Single workspace mode

Allow images in {structurizrDataDirectory}/images to be available via http://localhost:8080/workspace/images

Multi-workspace mode

Allow images in {structurizrDataDirectory}/{workspaceId}/images to be available via http://localhost:8080/workspace/{workspaceId}/images

Priority

I'm willing to add this feature myself and raise a PR (please confirm approach first)

More information

No response

@simonbrowndotje simonbrowndotje added the enhancement New feature or request label Oct 9, 2024
simonbrowndotje added a commit that referenced this issue Oct 9, 2024
simonbrowndotje added a commit to structurizr/ui that referenced this issue Oct 9, 2024
…orkspace}/images/filename.ext" ... for use with Structurizr Lite (see structurizr/lite#165)
judgedim added a commit to judgedim/lite that referenced this issue Oct 12, 2024
@judgedim
Copy link

judgedim commented Oct 12, 2024

@simonbrowndotje have tested your changes related to this issue, and the solution works well (I added a small PR to make it a bit more flexible). Do you have any objections if I open the same issue for https://github.com/structurizr/onpremises ?

@simonbrowndotje
Copy link
Contributor Author

Switching {filename} to {*filename} seems to permit sub-directories ... see 8f82aa4

Feel free to open an issue for the on-premises installation, but adding the same functionality requires some additional thought ... most users will not have direct access to the file system (or blob store) sitting behind the installation, and there's no way to upload arbitrary images at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants