-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type = "success" to Banner component and/or update Banner documentation to include "Toast" #942
Comments
I see your point. The reason this banner type does not exist is because Stripe's own design system guidance is not to use banners to communicate transitory success statuses. Instead we recommend using the Hope that helps! |
You can close this issue. I created a positive banner component.
Typically my app would display unshipped invoices as a list. The user story here is they need a static notification when there's nothing to ship. In relation to my app, a success banner is the anti "happy-path" as defined in the docs: For example: |
Here's another use case for the "success" type banner: In a private app, we want our administrators to know how to deal with canceled subscriptions with active SIM card ICCIDs on their accounts. We use: {obj?.subscription && !iccid && <Banner
title="No ICCID found"
type="critical"
description={obj.subscription.status === "canceled" ? "Nothing more to do here. Canceled subscriptions do not need an ICCID." :
"Please ask the customer to add an ICCID to the subscription or ask them to cancel their subscription"}
/>} We have created a positive banner component but it feels like this is a missed opportunity with the Stripe Apps platform. While we can use our PositiveBanner component when we would like to use: {obj?.subscription && !iccid && <Banner
title="No ICCID found"
type={obj.subscription.status === "canceled" ? "success" :"critical"}
description={obj.subscription.status === "canceled" ? "Nothing more to do here. Canceled subscriptions do not need an ICCID." :
"Please ask the customer to add an ICCID to the subscription or ask them to cancel their subscription"} />} For an additional use-case reference, Stripe uses a positive banner at https://dashboard.stripe.com/developers: |
I'm creating a shipping app that displays a message to the user if there are no shipments that are unshipped. I'm using a banner component. It would be nice if there were a different icon to display to the user when the banner is a positive message. For example, my banner looks out of place here with an exclamation point:
It would be nice if the banner displayed a green check mark if the status of the message was positive.
A workaround would be to create a component with an icon and border with the appropriate styling, but this seems like it should be part of the functionality of the Banner component.
The text was updated successfully, but these errors were encountered: