Skip to content
This repository has been archived by the owner on Sep 21, 2021. It is now read-only.

Extraneous output #12

Open
briansorahan opened this issue May 18, 2017 · 1 comment
Open

Extraneous output #12

briansorahan opened this issue May 18, 2017 · 1 comment

Comments

@briansorahan
Copy link

Using this tool for the very first time, I was curious why the output is so verbose.
Here is what I see:

Found 3 potentially unsafe SQL statements:
<LIST OF FILES WITH PROBLEMS>
Please ensure that all SQL queries you use are compile-time constants.
You should always use parameterized queries or prepared statements
instead of building queries from strings.

Do we gain anything from all the extra output or could we just output a list of problematic files?
I'd be happy to open a PR if y'all think we should trim down the output.

I think the informational lines would be more appropriate in the output of safesql -h what do you think?

@melvinsh
Copy link

I think saying You're safe from SQL injection! Yay \o/ is also a really bad idea because this tool can not guarantee that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants