-
Notifications
You must be signed in to change notification settings - Fork 29
docs(mtls): add example in combination with 'KafkaTopic' and 'KafkaUser' #231
base: main
Are you sure you want to change the base?
Conversation
afb248a
to
4af7596
Compare
Signed-off-by: Sebastian Gaiser <[email protected]>
Co-authored-by: Paolo Patierno <[email protected]> Signed-off-by: Sebastian Gaiser <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Maybe we should add some README.md into the folder with some explanation?
- Maybe we should make it in the path a bit more clear that this is about linking it with Strimzi-based Kafka cluster and not as muhc about mTLS as the path suggests? E.g.
packaging/examples/strimzi-tls-auth
? - It seems disconnected from the release tooling. So if we ever do another release of this, nothing will hapen with this. So I guess the
MAkefile
tasks should be updated to:- Include this in the release package
- Copy it to
/examples
- Make sure the Deployment YAML is up to date (I think having a separate deployment is a bit controversial as it would get easily out of date. But not sure how to do it better other thn having just a README.md with YAML snippets.)
- Update the Deployment YAML during release with the release version (to use the correct container)
I guess having this just as a section in the main README.md would safe a lot of these things. But I'm fine if we want to have it in examples. We just have to make sure it is done properly or it will be obsolete and forgotten soon.
If you want I can move the files to a different path, split them up, ... Please tell me where :D The structure of the readme and the makefile parts are not on me, I guess. So maybe this should be in another PR. |
I think there are several problems with this:
If we merge it as it is, it will never be part of any release, most people will never find it and it will eventually get outdated until it is one day deleted. That is what I'm afraid of. |
Would the releasing be easier with a Helm chart? I think this would not be that kind of documentation but in case when you run |
Well, yes and not I guess. We would still need to integrate it into the tooling and CIs. |
closes #230