Correctly handle KafkaMetric metrics #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mickael Maison <[email protected]>
Signed-off-by: Mickael Maison <[email protected]>
scholzj
approved these changes
Sep 12, 2024
scholzj
pushed a commit
that referenced
this pull request
Sep 30, 2024
Signed-off-by: Mickael Maison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #44 the collector was incorrectly caching the metric value, meaning that each collection reported the same initial value.
This also fixes a HTTP server leak in
PrometheusMetricsReporterConfigTestwhich caused intermittent test flakiness. To find it I usedslf4j-simpleto get tracing output from the tests. Since it proved useful, I propose adding it as a test dependency.