-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for consumer event listener #259
Comments
Yes, you can see the following code in notifyActiveConsumerChanged(activeConsumer);
readMoreEntries(activeConsumer); Only after the
I prefer the latter one as well.. The first one is more Java-style, which is not easy to use IMO. |
I am agree with @BewareMyPower, the latter is better. To me, this syntax is more idiomatic than the first one.
I think it is better to use the main channel with an enum. |
We're interested in adding support for this feature that already exists in the Java client. I have quickly looked at the code and most of the logic to handle active/inactive events is already in place. What remains to be implemented is surfacing the event to the user.
First, I have one question:
Is there any guarantee that when a consumer becomes active for a topic, it always receives a
CommandActiveConsumerChange
before the first message?I see a few options regarding the public API:
The latter is, IMHO, easier to consume for the end user.
Regarding the implementation strategy, we can reuse the main message channel with an enum, or handle events in a separate channel.
Thoughts?
The text was updated successfully, but these errors were encountered: