-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a way to acknowledge a message only with Id #245
Comments
Oh, |
And I have some more ideas for the API:
|
@zamazan4ik It may be fixed by the merged PR #252 from @ChillFish8 Can you check and close if it satisfies your needs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi.
Right now library provides a way to acknowledge a message with the following function: https://docs.rs/pulsar/latest/pulsar/consumer/struct.Consumer.html#method.ack
As you see, it consumes the whole
Message
as a ref. However, internally it uses only an Id field. During the integration of acknowledgment mechanism into Vector I have found that would be much more convenient to have a way just to pass an id instead of the whole message (at least becauseMessage
does not supportClone
).Could you please change the corresponding method (would be a breaking change, I guess) or provide an additional method smth like
ack_with_message_id
to resolve the problem? Thanks!P.S. Yeah, I know that I can grab
acker
and emulate the same behavior with it. I think havingack_with_message_id
has better UX for the users.The text was updated successfully, but these errors were encountered: