Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multitopicproducer is not official spec for pulsar-client #229

Open
DonghunLouisLee opened this issue Sep 1, 2022 · 2 comments
Open

Multitopicproducer is not official spec for pulsar-client #229

DonghunLouisLee opened this issue Sep 1, 2022 · 2 comments
Assignees
@DonghunLouisLee

Comments

@DonghunLouisLee
Copy link
Collaborator

I believe multi topic producer is not a required spec for pulsar clients and I think it's highly unnecessary with misleading configurations such as "batch" being separate configs for each producers.

I'm thinking of removing this feature since maintaining this sorts of does not align with implementing #213.
@DonghunLouisLee DonghunLouisLee changed the title Multitopicproducer official support? Multitopicproducer is not official spec for pulsar-client Sep 1, 2022
@DonghunLouisLee DonghunLouisLee self-assigned this Sep 1, 2022
@DonghunLouisLee
Copy link
Collaborator Author

moreover, pulsar client struct does not need to have the ability to produce messages directly. Producer should be built to send messages only. Having client struct impl send, send_raw is unnecessary.

@tisonkun
Copy link
Contributor

Why do we implement this struct in the first place?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DonghunLouisLee DonghunLouisLee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tisonkun @DonghunLouisLee