-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"kebab" method improperly used on style value in data URL #206
Comments
Turns out it's the prefixer plugin. I've submitted #208 to fix it. |
streamich
pushed a commit
that referenced
this issue
Sep 18, 2018
* Properly kebab ms prefix Also added test * Reworked prefixer to be smarter Instead of blindly splitting on ';', we can instead return an object from .prefixer() and then use that to build the string. I think it's cleaner this way. Closes #206
streamich
pushed a commit
that referenced
this issue
Sep 18, 2018
# [3.4.0](v3.3.0...v3.4.0) (2018-09-18) ### Features * better prefixing ([e5e83c4](e5e83c4)), closes [#206](#206)
🎉 This issue has been resolved in version 3.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is related to #203, but slightly different.
We stopped using the "important" addon because we finally excised all SASS files, but this is causing issues.
We have a style definition of this:
It generates the following style:
Notice how the characters "utf8,%3Csvg" got converted to "utf8,%3-csvg". That breaks the XML and causes the rule to be dropped by the browser.
The correct rule is:
Note: I'm assuming that kebab is to blame here, but I don't really know. It's quite possible that kebab shouldn't be run on url() values.
The text was updated successfully, but these errors were encountered: