Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pool and JDC update nTime field with current timestamp - they should use the one sent by TP #1324

Closed
GitGab19 opened this issue Jan 2, 2025 · 0 comments · Fixed by #1325
Closed

Pool and JDC update nTime field with current timestamp - they should use the one sent by TP #1324

GitGab19 opened this issue Jan 2, 2025 · 0 comments · Fixed by #1325
Assignees
@GitGab19
Labels
bug Something isn't working

Comments

@GitGab19
Copy link
Collaborator

GitGab19 commented Jan 2, 2025 •
edited
Loading

Our current Pool and JDC update the nTime field of every job using the current system time, instead of using the value sent by TP. This leads to mine invalid blocks when the value is too old with respect to the network one. We were able to notice this bug on testnet4, since its MTP is moved in the future.

Here some logs which shows TP logs when this bug is in place:

timestamp-bug

cc @Sjors
@GitGab19 GitGab19 added the bug Something isn't working label Jan 2, 2025
@GitGab19 GitGab19 self-assigned this Jan 2, 2025
@GitGab19 GitGab19 mentioned this issue Jan 2, 2025
Merged
GitGab19 added a commit to GitGab19/stratum that referenced this issue Jan 8, 2025
@GitGab19
bump PATCH after timestamp-bug fix (stratum-mining#1324)
e4cfe3b
@github-project-automation github-project-automation bot moved this from Todo 📝 to Done ✅ in SV2 Roadmap 🛣️ Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GitGab19 GitGab19

Labels
bug Something isn't working
Projects
SV2 Roadmap 🛣️
Status: Done ✅
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix timestamp bug - min_ntime becomes always the one sent by TP GitGab19/stratum
1 participant
@GitGab19