From 235179a7c0c0dc51ec8706977313c9776b81ea43 Mon Sep 17 00:00:00 2001
From: Kaku <105181329+kakucodes@users.noreply.github.com>
Date: Tue, 17 Sep 2024 15:31:13 -0500
Subject: [PATCH] cosmwasm: updated tests for wormchain-ibc-receiver

---
 .../wormchain-ibc-receiver/src/tests.rs       | 101 ------
 .../wormchain-ibc-receiver/src/tests/mod.rs   |   2 +
 .../src/tests/test_utils.rs                   |  66 ++++
 .../wormchain-ibc-receiver/src/tests/tests.rs | 311 ++++++++++++++++++
 4 files changed, 379 insertions(+), 101 deletions(-)
 delete mode 100644 cosmwasm/contracts/wormchain-ibc-receiver/src/tests.rs
 create mode 100644 cosmwasm/contracts/wormchain-ibc-receiver/src/tests/mod.rs
 create mode 100644 cosmwasm/contracts/wormchain-ibc-receiver/src/tests/test_utils.rs
 create mode 100644 cosmwasm/contracts/wormchain-ibc-receiver/src/tests/tests.rs

diff --git a/cosmwasm/contracts/wormchain-ibc-receiver/src/tests.rs b/cosmwasm/contracts/wormchain-ibc-receiver/src/tests.rs
deleted file mode 100644
index f76801b280..0000000000
--- a/cosmwasm/contracts/wormchain-ibc-receiver/src/tests.rs
+++ /dev/null
@@ -1,101 +0,0 @@
-use std::marker::PhantomData;
-
-use crate::contract::submit_vaas;
-use anyhow::Error;
-use cosmwasm_std::{
-    testing::{mock_info, MockApi, MockQuerier, MockStorage},
-    to_binary, Binary, ContractResult, Empty, OwnedDeps, SystemResult, Uint256,
-};
-use serde::Serialize;
-use wormhole_bindings::{fake::WormholeKeeper, WormholeQuery};
-use wormhole_sdk::{
-    token::Message,
-    vaa::{Body, Header, Vaa},
-    Address, Amount,
-};
-
-fn create_vaa_body(i: usize) -> Body<Message> {
-    Body {
-        timestamp: i as u32,
-        nonce: i as u32,
-        emitter_chain: (i as u16).into(),
-        emitter_address: Address([(i as u8); 32]),
-        sequence: i as u64,
-        consistency_level: 32,
-        payload: Message::Transfer {
-            amount: Amount(Uint256::from(i as u128).to_be_bytes()),
-            token_address: Address([(i + 1) as u8; 32]),
-            token_chain: (i as u16).into(),
-            recipient: Address([i as u8; 32]),
-            recipient_chain: ((i + 2) as u16).into(),
-            fee: Amount([0u8; 32]),
-        },
-    }
-}
-
-pub fn sign_vaa_body<P: Serialize>(wh: WormholeKeeper, body: Body<P>) -> (Vaa<P>, Binary) {
-    let data = serde_wormhole::to_vec(&body).unwrap();
-    let signatures = WormholeKeeper::new().sign(&data);
-
-    let header = Header {
-        version: 1,
-        guardian_set_index: wh.guardian_set_index(),
-        signatures,
-    };
-
-    let v = (header, body).into();
-    let data = serde_wormhole::to_vec(&v).map(From::from).unwrap();
-
-    (v, data)
-}
-
-fn mock_wormhole_deps(
-    wh: &WormholeKeeper,
-) -> OwnedDeps<cosmwasm_std::MemoryStorage, MockApi, MockQuerier<WormholeQuery>, WormholeQuery> {
-    let wh = WormholeKeeper::new();
-
-    let querier: MockQuerier<WormholeQuery> =
-        MockQuerier::new(&[]).with_custom_handler(move |q| match q {
-            WormholeQuery::VerifyVaa { vaa } => match wh.verify_vaa(&vaa.0, 0u64) {
-                Ok(_) => SystemResult::Ok(if let Ok(data) = to_binary(&Empty {}) {
-                    ContractResult::Ok(data)
-                } else {
-                    ContractResult::Err("Unable to convert to binary".to_string())
-                }),
-                Err(e) => SystemResult::Ok(ContractResult::Err(e.to_string())),
-            },
-            _ => cosmwasm_std::SystemResult::Ok(cosmwasm_std::ContractResult::Ok(
-                to_binary(&Empty {}).unwrap(),
-            )),
-        });
-
-    OwnedDeps {
-        storage: MockStorage::default(),
-        api: MockApi::default(),
-        querier,
-        custom_query_type: PhantomData::<WormholeQuery>,
-    }
-}
-
-#[test]
-pub fn receiver_test() -> anyhow::Result<(), Error> {
-    let wh = WormholeKeeper::new();
-    let mut wormhole_deps = mock_wormhole_deps(&wh);
-    let mut_deps = wormhole_deps.as_mut();
-
-    let info = mock_info("sender", &[]);
-
-    let vaa_body = create_vaa_body(1);
-    let (signed_vaa, vaa_bin) = sign_vaa_body(wh.clone(), vaa_body);
-
-    let submissions = submit_vaas(mut_deps, info, vec![vaa_bin]);
-
-    println!("{:?}", submissions);
-
-    assert!(
-        submissions.is_err(),
-        "The supplied vaa is not a governance VAA and should fail to be accepted"
-    );
-
-    Ok(())
-}
diff --git a/cosmwasm/contracts/wormchain-ibc-receiver/src/tests/mod.rs b/cosmwasm/contracts/wormchain-ibc-receiver/src/tests/mod.rs
new file mode 100644
index 0000000000..287a6fbfc9
--- /dev/null
+++ b/cosmwasm/contracts/wormchain-ibc-receiver/src/tests/mod.rs
@@ -0,0 +1,2 @@
+pub mod test_utils;
+pub mod tests;
diff --git a/cosmwasm/contracts/wormchain-ibc-receiver/src/tests/test_utils.rs b/cosmwasm/contracts/wormchain-ibc-receiver/src/tests/test_utils.rs
new file mode 100644
index 0000000000..702d83bf7c
--- /dev/null
+++ b/cosmwasm/contracts/wormchain-ibc-receiver/src/tests/test_utils.rs
@@ -0,0 +1,66 @@
+use cosmwasm_std::{Binary, Uint256};
+use serde::Serialize;
+use wormhole_bindings::fake::WormholeKeeper;
+use wormhole_sdk::{
+    ibc_receiver::{Action, GovernancePacket},
+    token::Message,
+    vaa::{Body, Header, Vaa},
+    Address, Amount, Chain, GOVERNANCE_EMITTER,
+};
+
+pub fn create_transfer_vaa_body(i: usize) -> Body<Message> {
+    Body {
+        timestamp: i as u32,
+        nonce: i as u32,
+        emitter_chain: (i as u16).into(),
+        emitter_address: Address([(i as u8); 32]),
+        sequence: i as u64,
+        consistency_level: 32,
+        payload: Message::Transfer {
+            amount: Amount(Uint256::from(i as u128).to_be_bytes()),
+            token_address: Address([(i + 1) as u8; 32]),
+            token_chain: (i as u16).into(),
+            recipient: Address([i as u8; 32]),
+            recipient_chain: ((i + 2) as u16).into(),
+            fee: Amount([0u8; 32]),
+        },
+    }
+}
+
+pub fn create_gov_vaa_body(
+    i: usize,
+    chain_id: Chain,
+    channel_id: [u8; 64],
+) -> Body<GovernancePacket> {
+    Body {
+        timestamp: i as u32,
+        nonce: i as u32,
+        emitter_chain: Chain::Solana,
+        emitter_address: GOVERNANCE_EMITTER,
+        sequence: i as u64,
+        consistency_level: 0,
+        payload: GovernancePacket {
+            chain: Chain::Wormchain,
+            action: Action::UpdateChannelChain {
+                channel_id,
+                chain_id,
+            },
+        },
+    }
+}
+
+pub fn sign_vaa_body<P: Serialize>(wh: WormholeKeeper, body: Body<P>) -> (Vaa<P>, Binary) {
+    let data = serde_wormhole::to_vec(&body).unwrap();
+    let signatures = WormholeKeeper::new().sign(&data);
+
+    let header = Header {
+        version: 1,
+        guardian_set_index: wh.guardian_set_index(),
+        signatures,
+    };
+
+    let v = (header, body).into();
+    let data = serde_wormhole::to_vec(&v).map(From::from).unwrap();
+
+    (v, data)
+}
diff --git a/cosmwasm/contracts/wormchain-ibc-receiver/src/tests/tests.rs b/cosmwasm/contracts/wormchain-ibc-receiver/src/tests/tests.rs
new file mode 100644
index 0000000000..ef408d5c22
--- /dev/null
+++ b/cosmwasm/contracts/wormchain-ibc-receiver/src/tests/tests.rs
@@ -0,0 +1,311 @@
+use crate::{
+    contract::{query, submit_vaas},
+    msg::{AllChannelChainsResponse, QueryMsg},
+    tests::test_utils::{create_gov_vaa_body, create_transfer_vaa_body, sign_vaa_body},
+};
+use anyhow::Error;
+use cosmwasm_std::{
+    from_binary,
+    testing::{mock_env, mock_info, MockApi, MockQuerier, MockStorage},
+    to_binary, Binary, ContractResult, Deps, DepsMut, Empty, QuerierWrapper, SystemResult,
+};
+use wormhole_bindings::{fake::WormholeKeeper, WormholeQuery};
+use wormhole_sdk::{
+    ibc_receiver::{Action, GovernancePacket},
+    vaa::Body,
+    Chain, GOVERNANCE_EMITTER,
+};
+
+#[test]
+pub fn add_channel_chain_happy_path() -> anyhow::Result<(), Error> {
+    let wh = WormholeKeeper::new();
+
+    let querier: MockQuerier<WormholeQuery> =
+        MockQuerier::new(&[]).with_custom_handler(|q| match q {
+            WormholeQuery::VerifyVaa { vaa } => {
+                match WormholeKeeper::new().verify_vaa(&vaa.0, 0u64) {
+                    Ok(_) => SystemResult::Ok(if let Ok(data) = to_binary(&Empty {}) {
+                        ContractResult::Ok(data)
+                    } else {
+                        ContractResult::Err("Unable to convert to binary".to_string())
+                    }),
+                    Err(e) => SystemResult::Ok(ContractResult::Err(e.to_string())),
+                }
+            }
+            _ => cosmwasm_std::SystemResult::Ok(cosmwasm_std::ContractResult::Ok(
+                to_binary(&Empty {}).unwrap(),
+            )),
+        });
+
+    let mut mut_deps = DepsMut {
+        storage: &mut MockStorage::default(),
+        api: &MockApi::default(),
+        querier: QuerierWrapper::new(&querier),
+    };
+    let info = mock_info("sender", &[]);
+    let env = mock_env();
+
+    let add_sei_channel_body = create_gov_vaa_body(1, Chain::Sei, *b"\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00channel-0");
+    let (_, add_sei_vaa_binary) = sign_vaa_body(wh.clone(), add_sei_channel_body);
+
+    let submissions = submit_vaas(mut_deps.branch(), info.clone(), vec![add_sei_vaa_binary]);
+
+    assert!(
+        submissions.is_ok(),
+        "A proper UpdateChannelChain gov vaa should be accepted"
+    );
+
+    // create a readonly deps to use for querying the state
+    let empty_mock_querier = MockQuerier::<Empty>::new(&[]);
+    let readonly_deps = Deps {
+        storage: mut_deps.storage,
+        api: mut_deps.api,
+        querier: QuerierWrapper::new(&empty_mock_querier),
+    };
+
+    let channel_binary = query(readonly_deps.clone(), env, QueryMsg::AllChannelChains {})?;
+    let channel: AllChannelChainsResponse = from_binary(&channel_binary)?;
+
+    assert_eq!(channel.channels_chains.len(), 1);
+    let channel_entry = channel.channels_chains.first().unwrap();
+    assert_eq!(
+        channel_entry.0,
+        Binary::from(*b"channel-0"),
+        "the stored channel for sei should initially be channel-0"
+    );
+    assert_eq!(
+        channel_entry.1,
+        Into::<u16>::into(Chain::Sei),
+        "the stored channel should be for sei's chain id"
+    );
+
+    Ok(())
+}
+
+#[test]
+pub fn add_channel_chain_happy_path_multiple() -> anyhow::Result<(), Error> {
+    let wh = WormholeKeeper::new();
+
+    let querier: MockQuerier<WormholeQuery> =
+        MockQuerier::new(&[]).with_custom_handler(|q| match q {
+            WormholeQuery::VerifyVaa { vaa } => {
+                match WormholeKeeper::new().verify_vaa(&vaa.0, 0u64) {
+                    Ok(_) => SystemResult::Ok(if let Ok(data) = to_binary(&Empty {}) {
+                        ContractResult::Ok(data)
+                    } else {
+                        ContractResult::Err("Unable to convert to binary".to_string())
+                    }),
+                    Err(e) => SystemResult::Ok(ContractResult::Err(e.to_string())),
+                }
+            }
+            _ => cosmwasm_std::SystemResult::Ok(cosmwasm_std::ContractResult::Ok(
+                to_binary(&Empty {}).unwrap(),
+            )),
+        });
+
+    let mut mut_deps = DepsMut {
+        storage: &mut MockStorage::default(),
+        api: &MockApi::default(),
+        querier: QuerierWrapper::new(&querier),
+    };
+    let info = mock_info("sender", &[]);
+
+    let add_inj_channel_body = create_gov_vaa_body(2, Chain::Injective, *b"\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00channel-1");
+    let (_, add_inj_vaa_bin) = sign_vaa_body(wh.clone(), add_inj_channel_body);
+    let add_sei_channel_body = create_gov_vaa_body(3, Chain::Sei, *b"\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00channel-2");
+    let (_, add_sei_vaa_binary) = sign_vaa_body(wh.clone(), add_sei_channel_body);
+
+    // add a channel for injective and update the channel set for sei
+    let submissions = submit_vaas(
+        mut_deps.branch(),
+        info.clone(),
+        vec![add_sei_vaa_binary, add_inj_vaa_bin],
+    );
+
+    assert!(
+        submissions.is_ok(),
+        "A pair of proper UpdateChannelChain gov vaas should be accepted"
+    );
+
+    // create a readonly deps to use for querying the state
+    let empty_mock_querier = MockQuerier::<Empty>::new(&[]);
+    let readonly_deps = Deps {
+        storage: mut_deps.storage,
+        api: mut_deps.api,
+        querier: QuerierWrapper::new(&empty_mock_querier),
+    };
+
+    // refetch all the channels that are in state
+    let channel_binary = query(readonly_deps, mock_env(), QueryMsg::AllChannelChains {})?;
+    let AllChannelChainsResponse {
+        channels_chains: mut channels,
+    }: AllChannelChainsResponse = from_binary(&channel_binary)?;
+
+    channels.sort_by(|(_, a_chain_id), (_, b_chain_id)| a_chain_id.cmp(b_chain_id));
+
+    assert_eq!(channels.len(), 2);
+
+    let channel_entry = channels.first().unwrap();
+    assert_eq!(
+        channel_entry.0,
+        Binary::from(*b"channel-1"),
+        "the stored channel should be channel-1 "
+    );
+    assert_eq!(
+        channel_entry.1,
+        Into::<u16>::into(Chain::Injective),
+        "the stored channel should be for injective's chain id"
+    );
+
+    let channel_entry = channels.last().unwrap();
+    assert_eq!(
+        channel_entry.0,
+        Binary::from(*b"channel-2"),
+        "the stored channel should be channel-2"
+    );
+    assert_eq!(
+        channel_entry.1,
+        Into::<u16>::into(Chain::Sei),
+        "the stored channel should be for sei's chain id"
+    );
+
+    Ok(())
+}
+
+#[test]
+pub fn reject_invalid_add_channel_chain_vaas() {
+    let wh = WormholeKeeper::new();
+
+    let querier: MockQuerier<WormholeQuery> =
+        MockQuerier::new(&[]).with_custom_handler(|q| match q {
+            WormholeQuery::VerifyVaa { vaa } => {
+                match WormholeKeeper::new().verify_vaa(&vaa.0, 0u64) {
+                    Ok(_) => SystemResult::Ok(if let Ok(data) = to_binary(&Empty {}) {
+                        ContractResult::Ok(data)
+                    } else {
+                        ContractResult::Err("Unable to convert to binary".to_string())
+                    }),
+                    Err(e) => SystemResult::Ok(ContractResult::Err(e.to_string())),
+                }
+            }
+            _ => cosmwasm_std::SystemResult::Ok(cosmwasm_std::ContractResult::Ok(
+                to_binary(&Empty {}).unwrap(),
+            )),
+        });
+
+    let mut mut_deps = DepsMut {
+        storage: &mut MockStorage::default(),
+        api: &MockApi::default(),
+        querier: QuerierWrapper::new(&querier),
+    };
+    let info = mock_info("sender", &[]);
+
+    let add_channel_body = create_gov_vaa_body(1, Chain::Wormchain, *b"\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00channel-0");
+    let (_, add_vaa_binary) = sign_vaa_body(wh.clone(), add_channel_body);
+
+    let submissions = submit_vaas(mut_deps.branch(), info.clone(), vec![add_vaa_binary]);
+
+    assert!(
+        submissions.is_err(),
+        "Cannot add a channel from Gateway to Gateway"
+    );
+
+    let submissions = submit_vaas(
+        mut_deps.branch(),
+        info.clone(),
+        vec![Binary::from(vec![0u8; 32])],
+    );
+
+    assert!(
+        submissions.is_err(),
+        "VAA should be rejected if it cannot be parsed because it's too short"
+    );
+
+    let add_channel_body = create_transfer_vaa_body(1);
+    let (_, add_vaa_binary) = sign_vaa_body(wh.clone(), add_channel_body);
+
+    let submissions = submit_vaas(mut_deps.branch(), info.clone(), vec![add_vaa_binary]);
+
+    assert!(submissions.is_err(), "Can only execute governance vaas");
+
+    let add_channel_body = create_gov_vaa_body(1, Chain::Osmosis, *b"\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00channel-0");
+    let (_, add_vaa_binary) = sign_vaa_body(wh.clone(), add_channel_body);
+
+    let submissions = submit_vaas(mut_deps.branch(), info.clone(), vec![add_vaa_binary]);
+
+    assert!(
+        submissions.is_ok(),
+        "Can add a channel from Osmosis to Gateway"
+    );
+
+    let add_channel_body: Body<GovernancePacket> = Body {
+        timestamp: 1u32,
+        nonce: 1u32,
+        emitter_chain: Chain::Solana,
+        emitter_address: GOVERNANCE_EMITTER,
+        sequence: 1u64,
+        consistency_level: 0,
+        payload: GovernancePacket {
+            chain: Chain::Osmosis,
+            action: Action::UpdateChannelChain {
+                channel_id: *b"\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00channel-0",
+                chain_id: Chain::CosmosHub,
+            },
+        },
+    };
+    let (_, add_vaa_binary) = sign_vaa_body(wh.clone(), add_channel_body);
+
+    let submissions = submit_vaas(mut_deps.branch(), info.clone(), vec![add_vaa_binary]);
+
+    assert!(
+        submissions.is_err(),
+        "Cannot add a update a chain besides Gateway"
+    );
+}
+
+#[test]
+pub fn reject_replayed_add_channel_chain_vaas() {
+    let wh = WormholeKeeper::new();
+
+    let querier: MockQuerier<WormholeQuery> =
+        MockQuerier::new(&[]).with_custom_handler(|q| match q {
+            WormholeQuery::VerifyVaa { vaa } => {
+                match WormholeKeeper::new().verify_vaa(&vaa.0, 0u64) {
+                    Ok(_) => SystemResult::Ok(if let Ok(data) = to_binary(&Empty {}) {
+                        ContractResult::Ok(data)
+                    } else {
+                        ContractResult::Err("Unable to convert to binary".to_string())
+                    }),
+                    Err(e) => SystemResult::Ok(ContractResult::Err(e.to_string())),
+                }
+            }
+            _ => cosmwasm_std::SystemResult::Ok(cosmwasm_std::ContractResult::Ok(
+                to_binary(&Empty {}).unwrap(),
+            )),
+        });
+
+    let mut mut_deps = DepsMut {
+        storage: &mut MockStorage::default(),
+        api: &MockApi::default(),
+        querier: QuerierWrapper::new(&querier),
+    };
+    let info = mock_info("sender", &[]);
+
+    let add_channel_body = create_gov_vaa_body(1, Chain::Osmosis, *b"\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00channel-0");
+    let (_, add_vaa_binary) = sign_vaa_body(wh.clone(), add_channel_body);
+
+    let submissions = submit_vaas(
+        mut_deps.branch(),
+        info.clone(),
+        vec![add_vaa_binary.clone()],
+    );
+
+    assert!(
+        submissions.is_ok(),
+        "Can add a channel from Osmosis to Gateway"
+    );
+
+    let submissions = submit_vaas(mut_deps.branch(), info.clone(), vec![add_vaa_binary]);
+
+    assert!(submissions.is_err(), "Cannot replay the same VAA");
+}