Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Function Pausability #284

Open
sebsadface opened this issue Oct 23, 2024 · 0 comments
Open

Review Function Pausability #284

sebsadface opened this issue Oct 23, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@sebsadface
Copy link
Member

Description and context

Currently, the PoC protocol core contracts include a pausing feature that allows governance to pause certain contracts or functions. This issue serves as a reminder to review and adjust the pausability of existing functions and contracts to ensure they’re appropriately controlled.

Action Items

  • Review functions that are not currently pausable but may need to be:

    1. LicensingModule:
      a . attachLicenseTerms
    2. DisputeModule
      1. setArbitrationPolicy
      2. cancelDispute
      3. resolveDispute
      4. updateActiveArbitrationPolicy
      5. setBatchPermissions
      6. registerExternalRoyaltyPolicy
  • Review contracts that are currently pausable but may not need to be:

    1. EvenSplitGroupPool: All functions are only callable by the grouping module, which is already pausable, so additional pausability may be redundant.
@sebsadface sebsadface added the enhancement New feature or request label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant