Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate default licensing term setting #184

Open
Ramarti opened this issue Jul 10, 2024 · 0 comments
Open

Validate default licensing term setting #184

Ramarti opened this issue Jul 10, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Ramarti
Copy link

Ramarti commented Jul 10, 2024

Description and context

Even if this method is restricted, we can add some checks

function setDefaultLicenseTerms(address newLicenseTemplate, uint256 newLicenseTermsId) external restricted {
        LicenseRegistryStorage storage $ = _getLicenseRegistryStorage();
        $.defaultLicenseTemplate = newLicenseTemplate;
        $.defaultLicenseTermsId = newLicenseTermsId;
    }

Suggested solution

Add verification (registered template, check that the terms id exists)

Definition of done

Test case, code merged

@Ramarti Ramarti added the enhancement New feature or request label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant