drpchttp: add helpers for ALPN support #54
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ALPN is the "native" way to run multiple protocols over the same (encrypted) connection, and the common way to use it in go is via `net/http`'s "next protocol" support. Signed-off-by: Hank Donnay <[email protected]>
|
Here's the rendered documentation for the added bits. (Looks like firefox mangled it a bit, sorry.) |
|
I finally checked my emails and saw this PR. I haven't taken a detailed look yet (I'll try to do that tomorrow), but I think this might live better in the Also we do have gerrit at https://review.dev.storj.io/ but this works fine as well, whichever you prefer. I should add a link in the main README. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at using DRPC and would want to run it on the same server connection as an existing API. ALPN is the "native" way to do this, so I took a pass at implementing it. Sending a PR in case it's something that would be useful for upstream.
I couldn't find if there was a Gerrit instance this sort of thing should go to instead.