Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packit: Fix replacement of placeholders in post-upstream-clone #1078

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

nforro
Copy link
Contributor

@nforro nforro commented Nov 13, 2024

I'm not exactly sure why, but while the sed expression does work in Copr, it doesn't work in Packit sandbox environment when running propose-downstream, hence the failures: https://github.com/storaged-project/libblockdev/runs/32657399598

This should hopefully fix it.

@vojtechtrefny
Copy link
Member

I was wondering why it failed, I suspected it was because I made the release from a non-default branch, but I didn't have time to investigate it further. Interestingly it worked for the previous release two months ago: https://dashboard.packit.dev/jobs/propose-downstream/10806

Copy link
Member

@vojtechtrefny vojtechtrefny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@nforro
Copy link
Contributor Author

nforro commented Nov 13, 2024

Interestingly it worked for the previous release two months ago: https://dashboard.packit.dev/jobs/propose-downstream/10806

Right, but at that time there was still sed -E:

- 'sed -i -E "s/@WITH_.+@/1/g" dist/libblockdev.spec'

@vojtechtrefny
Copy link
Member

Interestingly it worked for the previous release two months ago: https://dashboard.packit.dev/jobs/propose-downstream/10806

Right, but at that time there was still sed -E:

- 'sed -i -E "s/@WITH_.+@/1/g" dist/libblockdev.spec'

Oh, I forgot about this change. Thanks again for the fix.

@vojtechtrefny vojtechtrefny merged commit 4d746d2 into storaged-project:master Nov 13, 2024
26 of 27 checks passed
@nforro nforro deleted the packit branch November 13, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants