feat: display verification phrase during space registration #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the new `pre` caveat and `startCursor` and `endCursor` from storacha/w3infra#139 to implement reverse paging. One unsatisfying issue with this is that paging backwards reverses the order of items in the uploads list, and that edge conditions behave fairly confusingly. Not entirely sure what to do about this yet, so pushing up for some feedback. This currently only works with a bunch of custom service config and `file:/` dependencies that I am not pushing up for now.
this brings in the necessary changes for reverse paging
- use icons instead of word buttons - make edge cases seem less weird by not rendering 0 sized pages
we don't have the bandwidth to support @w3ui/react anymore, so start migrating w3console to use the "headless" components directly this takes care of the markup, the next step is to get rid of custom CSS and move entirely over to idiomatic TailwindCSS styling
Since we're no longer using the external w3ui React "customizable" component library, we can use idiomatic TailwindCSS across the board. A few years ago I would have considered this a step backwards, moving from semantic classes to tailwind utility classes sprinkled everywhere. While there may be some opportunities for abstraction in a few places, Tailwind's docs make the case for being extremely conservative with this sort of CSS-level componentization: https://tailwindcss.com/docs/reusing-styles I have created a `w3ui-button` class, but it probably needs to be pared down - evidence for this can be found in the authenticator's "Register" button in which I needed to copy most of the styles from the `w3ui-button` class to customize it the way I wanted.
storacha/w3up#432 introduces a mechanism for providing "definitive verification of the validity of a [space registration] email request". A full justification for this flow is provided in that PR, and this PR updates w3ui and w3console to show the phrase generated by the access API.
travis
force-pushed
the
feat/verification-phrase
branch
from
2d12acf
to
9734cb2
Compare
8 tasks
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0d6b8ea:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
storacha/w3up#432 introduces a mechanism for providing "definitive verification of the validity of a [space registration] email request". A full justification for this flow is provided in that PR, and this PR updates w3ui and w3console to show the phrase generated by the access API.
New verification screen:
Still need to update verification email and will add a screenshot of that here.
Will need an updated access client to run locally and for checks to pass in this PR - storacha/w3up#432 can be merged safely without these changes so I'll update this PR once that's merged.