Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests should use Helia for all tests #377

Open
vasco-santos opened this issue May 21, 2024 · 0 comments
Open

Integration tests should use Helia for all tests #377

vasco-santos opened this issue May 21, 2024 · 0 comments

Comments

@vasco-santos
Copy link
Contributor

Currently blob.test.js has tests for bitswap using Helia commented. This is because trying to run a new Helia node triggers runtime errors in Node that look like previous node did not finish running and still has control of some resource. Given integration.test.js does exactly same test (and uses blob under the hood), it is not critical to make use of Helia again, but would be great to have it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant