Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a label that will leave subscription created objects when it is removed #204

Open
jnpacker opened this issue May 29, 2020 · 0 comments
Open

Add a label that will leave subscription created objects when it is removed #204

jnpacker opened this issue May 29, 2020 · 0 comments
Assignees
@jnpacker
Labels
enhancement New feature or request

Comments

@jnpacker
Copy link
Member

Going to add a label to the subscription that will not remove resources when the subscription itself is deleted.

subscription-delete-resources: true/false

I'm open to a better name. The default is "true"
@jnpacker jnpacker added the enhancement New feature or request label May 29, 2020
@jnpacker jnpacker self-assigned this May 29, 2020
chenz4027 pushed a commit that referenced this issue Jul 18, 2022
@lennysgarage
Add unit tests for synchronizer (#204)
5f118cc 
* Add test case to check invalid apiversion

Signed-off-by: Jonathan Marcantonio <[email protected]>

* Add test case to get appsub

Signed-off-by: Jonathan Marcantonio <[email protected]>

* Add test case to check namespace

Signed-off-by: Jonathan Marcantonio <[email protected]>

* Fix test case delete single subscribed resource

Signed-off-by: Jonathan Marcantonio <[email protected]>

* Fix spelling of override

Signed-off-by: Jonathan Marcantonio <[email protected]>

* Start synchronizer cache before test cases

Signed-off-by: Jonathan Marcantonio <[email protected]>

* Add test case to ProcessSubResources

Signed-off-by: Jonathan Marcantonio <[email protected]>

* Organize naming of appsubs

Signed-off-by: Jonathan Marcantonio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnpacker jnpacker

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jnpacker