Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leftover agent component docs and make targets? #535

Open
nirs opened this issue Nov 6, 2022 · 0 comments
Open

Leftover agent component docs and make targets? #535

nirs opened this issue Nov 6, 2022 · 0 comments

Comments

@nirs
Copy link

nirs commented Nov 6, 2022

README.md says:

1. Deploy foundation hub components on hub cluster and deploy foundation agent components on all managed clusters.

    ```sh
    make deploy-foundation
    ``` 

But make deploy-foundation deploys only the bug stuff:

$(KUSTOMIZE) build deploy/foundation/hub | $(KUBECTL) apply -f -

Looks like the agent component is part of the klusterlet operator now:

$ kubectl --context dr1 get deploy -n open-cluster-management-agent-addon 
NAME                       READY   UP-TO-DATE   AVAILABLE   AGE
klusterlet-addon-workmgr   1/1     1            1           15m

Looks like the text about agent component should be removed and/or refer
to the klusterlet operator.

The makefile includes target for the cleaning the agent compoenets:

clean-foundation-agent:
    $(KUBECTL) get managedclusteraddons -A | grep work-manager | awk '{print $$1" "$$2}' | xargs -n 2 $(KUBECTL) delete managedclusteraddons -n

But there is no code installing it in the makefile, so not sure why this code is
needed. If klusterlet-addon-workmgr is part of klusterlet, it should be removed
by klusterlet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant