From 99a7dac5de51fdcf2ebbc189dbe1d93cbac6c811 Mon Sep 17 00:00:00 2001 From: chris Date: Mon, 30 Sep 2024 15:27:20 +0200 Subject: [PATCH 1/2] ci: Add tests for PHP 8.4 --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f16ea8b9..19090ffa 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -41,7 +41,7 @@ jobs: strategy: fail-fast: false matrix: - php: [ '7.4', '8.0', '8.1', '8.2', '8.3' ] + php: [ '7.4', '8.0', '8.1', '8.2', '8.3', '8.4' ] name_suffix: [''] stability: ['stable'] composer_flags: [''] @@ -50,7 +50,7 @@ jobs: name_suffix: ' (lowest deps)' stability: 'stable' composer_flags: '--prefer-lowest' - - php: '8.3' + - php: '8.4' name_suffix: ' (dev deps)' stability: 'dev' composer_flags: '' From 2e47707172921085818abe31c589159d5af4f3fe Mon Sep 17 00:00:00 2001 From: Christopher Georg Date: Thu, 21 Nov 2024 16:37:22 +0100 Subject: [PATCH 2/2] feat: fix deprecation for implicit nullable parameter declarations --- src/EventListener/BlameListener.php | 2 +- src/EventListener/LoggerListener.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/EventListener/BlameListener.php b/src/EventListener/BlameListener.php index 5908605e..879fddcc 100644 --- a/src/EventListener/BlameListener.php +++ b/src/EventListener/BlameListener.php @@ -21,7 +21,7 @@ class BlameListener implements EventSubscriberInterface private ?TokenStorageInterface $tokenStorage; private BlameableListener $blameableListener; - public function __construct(BlameableListener $blameableListener, TokenStorageInterface $tokenStorage = null, AuthorizationCheckerInterface $authorizationChecker = null) + public function __construct(BlameableListener $blameableListener, ?TokenStorageInterface $tokenStorage = null, ?AuthorizationCheckerInterface $authorizationChecker = null) { $this->blameableListener = $blameableListener; $this->tokenStorage = $tokenStorage; diff --git a/src/EventListener/LoggerListener.php b/src/EventListener/LoggerListener.php index 79f91c35..dc06044b 100644 --- a/src/EventListener/LoggerListener.php +++ b/src/EventListener/LoggerListener.php @@ -28,7 +28,7 @@ class LoggerListener implements EventSubscriberInterface /** * @param LoggableListener $loggableListener */ - public function __construct(LoggableListener $loggableListener, TokenStorageInterface $tokenStorage = null, AuthorizationCheckerInterface $authorizationChecker = null) + public function __construct(LoggableListener $loggableListener, ?TokenStorageInterface $tokenStorage = null, ?AuthorizationCheckerInterface $authorizationChecker = null) { $this->loggableListener = $loggableListener; $this->tokenStorage = $tokenStorage;