Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXIT module not working #14

Open
sethtroisi opened this issue Mar 18, 2022 · 2 comments · May be fixed by #15
Open

EXIT module not working #14

sethtroisi opened this issue Mar 18, 2022 · 2 comments · May be fixed by #15

Comments

@sethtroisi
Copy link

Hey Stoermelder, I am super excited about using your EXIT module to chain a series of racks for an AV project.
I think the EXIT module is broken at head because of Rack 2 api changes? How can I help?

I used the latest module from the nightly tag but it didn't work. So I downloaded and compiled the module.

It looks like because the MB extension is disabled in b18ca9d#diff-5f6c4197f0142fbc04b0c77f4fe8294057a581a9f970721896e2c95abeec1e0c

When I uncomment the MenuBarEx::init(); I get a runtime error Rack: src/context.cpp:47: rack::Context* rack::contextGet(): Assertion threadContext' failed.`

I assume this is all known. What can I do to help fix the module?

@sethtroisi
Copy link
Author

I made some headway by simply removing uses of APP from init(). This causes step() to not be called but I can call step() directly during trigger(). This "works" in that I see [5.485 info src/patch.cpp:251 load] Loading patch /home/five/.Rack2/patches/test2.vcv in the log but then the VCV Rack locks up similar to what you described in https://community.vcvrack.com/t/loading-a-patch-from-plugin/6430/2

@sethtroisi
Copy link
Author

I managed to hack this back to working. my understanding is something like this.
When menuBarExButton::init() is called in a place without context (accessed when you call APP) it doesn't get added to the list of widgets and won't have step() called. If I call menuBarExButton::init() once from ExitWidget::ExitWidget(ExitModule* module) then context exists and everything works happily.

@sethtroisi sethtroisi linked a pull request Mar 19, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant