Fix error "assigning to &T is undefined behavior" and clippy warnings #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Rust 1.73.0, the compiler errors about assigning to a reference when casting it to a mutable pointer. See: https://doc.rust-lang.org/beta/rustc/lints/listing/deny-by-default.html#invalid-reference-casting
azerupi
force-pushed
the
fix-errors-warnings
branch
from
ddab4c2
to
f5f5853
Compare
jamwaffles
approved these changes
Jan 6, 2024
|
Gonna call this one good. Thanks for the fix, and sorry for the delay! |
|
No worries, thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Rust 1.73.0 there seems to be a new deny-by-default lint to catch invalid casting from references to mutable pointers.
As far as I understand the compiler is making assumptions that references are read only and passing those assumptions on to LLVM. The only way to tell the compiler to not make those assumptions is to use
UnsafeCell.So this PR is essentially wrapping those casts with
UnsafeCelland getting the mutable pointer through it.In addition to that I fixed some warnings from compiler lints and clippy lints.