-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StimulusReflex::Element and StimulusReflex Targets #687
Draft
Matt-Yorkley
wants to merge
15
commits into
stimulusreflex:main
Choose a base branch
from
Matt-Yorkley:targets
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for stimulusreflex ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: Marco Roth <[email protected]>
Co-authored-by: Marco Roth <[email protected]>
Co-authored-by: Marco Roth <[email protected]>
Fixes failing "selector can be overwritten" test in ReflexElementTest
… in StimulusReflex::Logger
Matt-Yorkley
force-pushed
the
targets
branch
from
February 25, 2024 15:01
7c7f258
to
4ab5b60
Compare
Matt-Yorkley
changed the title
StimulusReflex::Element and Stimulusreflex Targets
StimulusReflex::Element and StimulusReflex Targets
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
Description
Finishes off the proposed StimulusReflex Element and Stimulusreflex Targets features previously started in #489 and #490.
Adds named
element
(the element which called the reflex) and definabletargets
a little bit like theTargets API
in Stimulus, which can be interacted with in reflexes by applying (chainable)cable_ready
operations which can omit theselector
argument, eg:The above examples are all converted automatically into valid
cable_ready
operations against single or multiple targets (collections of targets with the same name), and broadcast at the end of the reflex.Defining targets and scoping targets
By default a reflex will not send targets data from the client side. Targets can be sent by setting the
data-include-targets
property (any truthy value) or targets can be restricted to elements within the parent controller by settingdata-include-targets="controller"
, eg:Checklist