Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused dependencies check does not consider Elm code in node_modules #236

Open
sentience opened this issue Apr 16, 2020 · 0 comments
Open

Comments

@sentience
Copy link

In our codebase, source-directories points to some libraries in node_modules:

    "source-directories": [
        ".",
        "../../../../lib/client/modules/ca-ui",
        "../../../../lib/client/modules/ca-utils",
        "../../../../node_modules/elm-upgrade-shims/lib-0.19",
        "../../../../node_modules/@kaizen/component-library/draft",
        "../../../../node_modules/@kaizen/component-library/components"
    ],

Since #22, elm-analyze doesn't scan files in node_modules, which is fine by us.

Unfortunately, some of the dependencies in elm.json may be consumed by some of the Elm modules in node_modules. We are therefore seeing false-positive “Unused dependencies” results.

Ideally, the "Unused dependencies" check should factor in Elm code in node_modules, even if the check results exclude it.

An interim work-around for us would also be the option to disable the "Unused dependencies" check, which does not currently seem to be possible in elm-analyse.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant