Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B♯ exists! #2

Open
jjt opened this issue Apr 7, 2015 · 4 comments
Open

B♯ exists! #2

jjt opened this issue Apr 7, 2015 · 4 comments

Comments

@jjt
Copy link

jjt commented Apr 7, 2015

Such as in the key of C♯ major, or an augmented E-G-B triad (which would be E-G-B♯, not E-G-C).

@jjt
Copy link
Author

jjt commented Apr 7, 2015

Nice project, BTW!

@stewdio
Copy link
Owner

stewdio commented Apr 7, 2015

Hello, and thanks! Well, I just did some more reading up on it and ... You got me! Do you know of a good concise explantation of that stuff that I myself can get up to speed on and can also link to? Man, I feel like The Simpsons really lied to me. Next you’re going to tell me that epidermis doesn’t mean “hair” 😉

So it sounds like BEEP.Note is in need of revision then, yes? Suggestions welcome!

@chris--young
Copy link

👍

@jjt
Copy link
Author

jjt commented Apr 9, 2015

The enharmonic equivalents wiki page is a good resource. I haven't had a chance to tuck into the code, but for now you could reword the README to something like

... Note will convert B♯ to its enharmonic equivalent ...

I would submit a PR, but your writing has a definite style that I won't try to ape :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants