FIP calculations and more data request abilities #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (ie. http://gd2.mlb.com/components/game/mlb/year_2014/pitchers/) that was previously unaccessible.
…the pitcher was loaded. All of this to allow for FIP comparison for games not yet played but with a linescore available (most future games, takes it from home/away probable pitchers)
…rors (ruby 2.1.2)
…itting out when unable to find future game.xml files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some changes/additions I made to allow for more requests from the server, in particular for pitchers. Also created method to calculate pitcher FIP. I'm a relative newbie to Ruby so feel free to adjust/give feedback on any of this.
I'm having a terrible time getting the gemfile to build correctly and cannot just use 'require 'pitcher'' in my tests when I build/install the gemfile myself, have you had luck building/installing the gemfile on your end?