Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: horizontal/vertical padding #540

Closed
wants to merge 1 commit into from

Conversation

ilyazz-zzayli
Copy link

This PR allows the user to specify different padding-values for the left and right sides (horizontal) and for the top and bottom sides (vertical).

@github-actions github-actions bot requested a review from stevearc December 20, 2024 14:03
@stevearc
Copy link
Owner

Thanks for the PR, but I do not want to merge this. There's a fine balance between adding customization options and making the config options too complex. In this case, you can already achieve this behavior in your own config by using the float.override function and changing the row/col/width/height of the window. Because it's already possible (albeit with slightly more effort), I don't think it's worth adding more special cases to the config shape.

@stevearc stevearc closed this Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants