From f5f67acf01cd1c372032420bd0aa09316ac38ec7 Mon Sep 17 00:00:00 2001 From: Jon Rood Date: Wed, 29 Dec 2021 12:50:53 -0700 Subject: [PATCH] Reintroduce readability-avoid-const-params-in-decls check and fix. (#532) --- .clang-tidy | 2 +- amr-wind/physics/EkmanSpiral.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 61148d5af7..c079095c0b 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -1,5 +1,5 @@ --- -Checks: 'clang-diagnostic-*,clang-analyzer-*,corecppguidelines-*,modernize-*,readability-*,-readability-magic-numbers,-readability-identifier-naming,-modernize-avoid-c-arrays,-modernize-use-trailing-return-type,-readability-named-parameter,-readability-implicit-bool-conversion,-readability-isolate-declaration,-readability-braces-around-statements,-readability-inconsistent-declaration-parameter-name,-modernize-use-emplace,-readability-qualified-auto,-readability-static-accessed-through-instance,-readability-container-size-empty,-readability-make-member-function-const,-readability-uppercase-literal-suffix,-readability-convert-member-functions-to-static,-readability-redundant-member-init,-modernize-use-bool-literals,-readability-const-return-type,-readability-avoid-const-params-in-decls,-modernize-pass-by-value,-clang-analyzer-optin.cplusplus.VirtualCall,-clang-analyzer-core.NonNullParamChecker' +Checks: 'clang-diagnostic-*,clang-analyzer-*,corecppguidelines-*,modernize-*,readability-*,-readability-magic-numbers,-readability-identifier-naming,-modernize-avoid-c-arrays,-modernize-use-trailing-return-type,-readability-named-parameter,-readability-implicit-bool-conversion,-readability-isolate-declaration,-readability-braces-around-statements,-readability-inconsistent-declaration-parameter-name,-modernize-use-emplace,-readability-qualified-auto,-readability-static-accessed-through-instance,-readability-container-size-empty,-readability-make-member-function-const,-readability-uppercase-literal-suffix,-readability-convert-member-functions-to-static,-readability-redundant-member-init,-modernize-use-bool-literals,-readability-const-return-type,-modernize-pass-by-value,-clang-analyzer-optin.cplusplus.VirtualCall,-clang-analyzer-core.NonNullParamChecker' WarningsAsErrors: '' HeaderFilterRegex: '^((?!/amrex/Src/|/googletest/).)*$' AnalyzeTemporaryDtors: false diff --git a/amr-wind/physics/EkmanSpiral.cpp b/amr-wind/physics/EkmanSpiral.cpp index afed8a9660..5410ff5616 100644 --- a/amr-wind/physics/EkmanSpiral.cpp +++ b/amr-wind/physics/EkmanSpiral.cpp @@ -12,7 +12,7 @@ namespace { struct UExact { AMREX_GPU_HOST_DEVICE AMREX_FORCE_INLINE amrex::Real - operator()(const amrex::Real, const amrex::Real, const amrex::Real) const; + operator()(amrex::Real, amrex::Real, amrex::Real) const; const int m_comp{0}; }; @@ -25,7 +25,7 @@ AMREX_GPU_HOST_DEVICE AMREX_FORCE_INLINE amrex::Real UExact::operator()( struct VExact { AMREX_GPU_HOST_DEVICE AMREX_FORCE_INLINE amrex::Real - operator()(const amrex::Real, const amrex::Real, const amrex::Real) const; + operator()(amrex::Real, amrex::Real, amrex::Real) const; const int m_comp{1}; };