From 323c0aa4d0a5acf562c08585fcf386b6de6fbaf4 Mon Sep 17 00:00:00 2001 From: Jon Rood Date: Wed, 29 Dec 2021 13:23:05 -0700 Subject: [PATCH] Reintroduce readability-const-return-type check and fix. (#533) --- .clang-tidy | 2 +- unit_tests/wind_energy/actuator/test_actuator_flat_plate.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index c079095c0b..f88f27ffd7 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -1,5 +1,5 @@ --- -Checks: 'clang-diagnostic-*,clang-analyzer-*,corecppguidelines-*,modernize-*,readability-*,-readability-magic-numbers,-readability-identifier-naming,-modernize-avoid-c-arrays,-modernize-use-trailing-return-type,-readability-named-parameter,-readability-implicit-bool-conversion,-readability-isolate-declaration,-readability-braces-around-statements,-readability-inconsistent-declaration-parameter-name,-modernize-use-emplace,-readability-qualified-auto,-readability-static-accessed-through-instance,-readability-container-size-empty,-readability-make-member-function-const,-readability-uppercase-literal-suffix,-readability-convert-member-functions-to-static,-readability-redundant-member-init,-modernize-use-bool-literals,-readability-const-return-type,-modernize-pass-by-value,-clang-analyzer-optin.cplusplus.VirtualCall,-clang-analyzer-core.NonNullParamChecker' +Checks: 'clang-diagnostic-*,clang-analyzer-*,corecppguidelines-*,modernize-*,readability-*,-readability-magic-numbers,-readability-identifier-naming,-modernize-avoid-c-arrays,-modernize-use-trailing-return-type,-readability-named-parameter,-readability-implicit-bool-conversion,-readability-isolate-declaration,-readability-braces-around-statements,-readability-inconsistent-declaration-parameter-name,-modernize-use-emplace,-readability-qualified-auto,-readability-static-accessed-through-instance,-readability-container-size-empty,-readability-make-member-function-const,-readability-uppercase-literal-suffix,-readability-convert-member-functions-to-static,-readability-redundant-member-init,-modernize-use-bool-literals,-modernize-pass-by-value,-clang-analyzer-optin.cplusplus.VirtualCall,-clang-analyzer-core.NonNullParamChecker' WarningsAsErrors: '' HeaderFilterRegex: '^((?!/amrex/Src/|/googletest/).)*$' AnalyzeTemporaryDtors: false diff --git a/unit_tests/wind_energy/actuator/test_actuator_flat_plate.cpp b/unit_tests/wind_energy/actuator/test_actuator_flat_plate.cpp index 26b9ee37f3..b1e5f5b760 100644 --- a/unit_tests/wind_energy/actuator/test_actuator_flat_plate.cpp +++ b/unit_tests/wind_energy/actuator/test_actuator_flat_plate.cpp @@ -50,7 +50,7 @@ struct FlatPlate : public act::WingType using MetaType = act::WingBaseData; using DataType = act::ActDataHolder; - static const std::string identifier() { return "TestFlatPlate"; } + static std::string identifier() { return "TestFlatPlate"; } }; } // namespace