Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New source form errors are not cleared after input values have been fixed #980

Open
alex-ketch opened this issue Jan 29, 2021 · 0 comments
Labels

Comments

@alex-ketch
Copy link
Contributor

alex-ketch commented Jan 29, 2021

If an input field contains an error, the form is not able to be re-submitted even after the issue has been addressed.
The only way to fix it is to reload the page.

To reproduce:

  1. Navigate to a Project on the Hub
  2. Add a new GitHub source
  3. Enter stenci.la as the Url
  4. Click Create Source button
  5. See Not a valid GitHub URL. error
  6. Fix the Url value by entering https://github.com/stencila/hub/blob/master/README.md
  7. Click Create Source button
  8. 🐛 Nothing happens, error is still shown
  9. Reload page, and enter correct Url from step 6
  10. Source is successfully created

As part of this issue, we should verify that this bug is not present on other forms.

@alex-ketch alex-ketch added the Bug label Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant