getEvents should still return a cursor if there are no events

[kalepail]

Describe the bug
When getEvents doesn't return any events, there is no cursor to paginate on.

But what if there are no events for a given filter? You may want to continue on but can't because there's no cursor. Especially given the way I think events are retrieved it's quite possible events are "missing" from your query and you need to paginate further for them.

[kalepail]

This is specifically in reference to the returned types

export interface GetEventsResponse {
        latestLedger: number;
        events: EventResponse[];
    }

[Shaptic]

It's in the EventResponse, either as pagingToken (deprecated), id, or cursor. I think we decided it makes more sense to have a per-event rather than per-page cursor.

[kalepail]

But what if there are no events for a given filter? You may want to continue on but can't because there's no cursor. Especially given the way I think events are retrieved it's quite possible events are "missing" from your query and you need to paginate further for them.

[Shaptic]

Oh, I'm a fool. We actually have cursor at the top level now rather than per-event. It's the API schema in the SDK that's wrong 🤦 fixed in stellar/js-stellar-sdk#1124, so closing this. Sorry for the confusion!

[kalepail]

fwiw there's a cursor at the top level AND per event from the RPC