soroban-rpc: evict ledger entries #925
Conversation
| if ledgerCloseMeta.V != 2 { | ||
| return fmt.Errorf("unexpected close meta version: %d", ledgerCloseMeta.V) | ||
| } | ||
| keysToEvict := make([]xdr.LedgerKey, len(ledgerCloseMeta.V2.EvictedTemporaryLedgerKeys)+len(ledgerCloseMeta.V2.EvictedPersistentLedgerEntries)) |
There was a problem hiding this comment.
we only need to process evicted temporary ledger keys because the evicted persistent ledger entries are already included in the change reader stream, see stellar/go#5037
I just started working on a similar pr which only handles temporary ledger key eviction https://github.com/stellar/soroban-tools/pull/926/files
There was a problem hiding this comment.
Unfortunately we can't transparently delete persistent ledger entries though (see TODO comment below) so I will need to detect them anyways.
There was a problem hiding this comment.
I think that you both are correct here, and the solution should be "other". In a similar way to core, we need to find a way ( or maybe not ? ) to help generate the restorefootprint for evicted ledger entries. however, that doesn't need to be handled in the same way. Core are going to store large bloom filters to accomodate that.
For the time being, no permanent entry is going to be evicted. however, before it does - we need to figure out how we address that.
| @@ -41,6 +41,17 @@ impl Contract { | |||
| env.storage().persistent().set(&COUNTER, &count); | |||
| } | |||
|
|
|||
| pub fn inc_tmp(env: Env) { | |||
| let mut count: u32 = env.storage().temporary().get(&COUNTER).unwrap_or(0); // Panic if the value of COUNTER is not u32. | |||
There was a problem hiding this comment.
I think it would be great if this change to the counter would be to a completely new key ( i.e. "TMP_COUNTER" ), so that we can be sure that we're testing the right thing.
What
Evict ledger entries when Core signals so through txmeta
Why
Fixes #914
Known limitations
The eviction test I added doesn't succeed after more than 10 minutes. Either there is something wrong in Core or the eviction takes too long to be testeable. I won't merge until that has been figured out.