Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit public methods #10

Open
Ifropc opened this issue Jul 29, 2024 · 1 comment
Open

Revisit public methods #10

Ifropc opened this issue Jul 29, 2024 · 1 comment

Comments

@Ifropc
Copy link
Contributor

Ifropc commented Jul 29, 2024

We should revisit methods we export publicly. Some methods available by the rpc-client should not be there, and instead should be moved to the cli. The main reason behind it is we want an rpc-client to be a "thin" client with no extra functionality.
Some context:

The lib started by extracting logic from the cli, but we extracted a lot more than just the client and the boundary between two had a lot of cli logic on the rpc client side. We've moved a lot over, but there's still things there.

From the discussion of
stellar/stellar-cli#1494

@willemneal
Copy link
Member

I still think we should have a second higher level crate that the CLI uses. It would be useful for anyone who wanted to use this crate separately from the CLI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants