Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] map & vec integrity/invariant checks #1148

Closed
4 tasks
graydon opened this issue Oct 31, 2023 · 0 comments · Fixed by #1247 · May be fixed by #1227
Closed
4 tasks

[test] map & vec integrity/invariant checks #1148

graydon opened this issue Oct 31, 2023 · 0 comments · Fixed by #1247 · May be fixed by #1227
Assignees
@sisuresh @jayz22
Labels
bug Something isn't working

Comments

@graydon
Copy link
Contributor

graydon commented Oct 31, 2023 •
edited
Loading

  • For every map construction path besides conversion (linear memory, element-wise construction, internal calls from iterators), check:

    • Out-of-order is rejected
    • Duplicates are rejected
    • Oversized maps are rejected

  • Also check oversized vecs in all the vec construction cases

Note the conversion variants of this are in #1147 and probably both of these can be done simultaneously or in adjacent tests
@graydon graydon added the bug Something isn't working label Oct 31, 2023
@graydon graydon changed the title [test] map invariant checks [test] map integrity/invariant checks Oct 31, 2023
@graydon graydon changed the title [test] map integrity/invariant checks [test] map & vec integrity/invariant checks Oct 31, 2023
@sisuresh sisuresh self-assigned this Nov 13, 2023
@sisuresh sisuresh mentioned this issue Nov 17, 2023
Open
@jayz22 jayz22 self-assigned this Nov 20, 2023
This was referenced Nov 21, 2023
Merged
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 29, 2023
@jayz22 @sisuresh
Add tests for invalid maps, oversized maps/vecs/bytes from various pa…
e39c7b3 
…ths (#1247)

### What

Resolves #1148 and
partially #1162

### Why

[TODO: Why this change is being made. Include any context required to
understand the why.]

### Known limitations

[TODO or N/A]

---------

Co-authored-by: Siddharth Suresh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sisuresh sisuresh

@jayz22 jayz22

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@graydon @sisuresh @jayz22