Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feeTable commas #707

Open
yuriescl opened this issue Oct 11, 2023 · 1 comment
Open

feeTable commas #707

yuriescl opened this issue Oct 11, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@yuriescl
Copy link
Contributor

In SEP-24 transaction form, there's a syntax error being raised due to a comma in the values:

image

image

This is where the value is getting rendered:

withdrawalFeeFixed: {{ asset.withdrawal_fee_fixed|default:0 }},

The fix is likely to adjust how the value gets rendered and remove the comma.

@yuriescl yuriescl added the bug Something isn't working label Oct 11, 2023
@yuriescl
Copy link
Contributor Author

I was able to resolve by setting settings.USE_THOUSAND_SEPARATOR to False:
https://docs.djangoproject.com/en/3.2/ref/settings/#use-thousand-separator

But Polaris should not use commas by default even if settings.USE_THOUSAND_SEPARATOR is True, otherwise will break the JavaScript syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant