Fix issue : Exc_bad_access call instance error in hook callback #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the use of unsafe_unretained'instance'in AspectInfo class modified member properties, when the callback if the object referred to by'instance' was released at this time because of the characteristics of unsafe_unretained, the object to which instance points is not set to nil, exc_bad_access will eventually lead to errors when used outside, I modified to solve the problem for weak; @Property (nonatomic, weak, readonly) id instance;
tuxi
changed the title
tuxi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello:
Problem Description: when I hook the viewDidDisappear: method in the callback when I use the callback information AspectInfo instance, always exc_bad_access error, I find the source and solve the trouble, you can see
the use of unsafe_unretained'instance'in AspectInfo class modified member properties,
when the callback if the object referred to by'instance' was released at this time because of the characteristics of unsafe_unretained,
the object to which instance points is not set to nil, exc_bad_access will eventually lead to errors when used outside,
I modified to solve the problem for weak;
@property (nonatomic, weak, readonly) id instance;